Well, changing the keyboard layout from obarun-install also change the system layout.
This is the expected behavior, no choice here. The script call loadkeys or setxkbmap program depending if you come from console or X.
You should get yourself some rest
i don't need rest but a job and money
I don't know what went wrong when I tried this first, it appeared as the old installer, now that I installed obarun-install and did it again I see all the changes.
Well, for the moment the /etc/obarun/install.conf is overwritten when you udpate the script (this behavior will change with the tagged release). So when you udpate from dev-eric branch the script overwritte the configuration file and you loose your change at the BRANCH variable and so if you do an update again without changing again the variable , the script will update from the master branch and you completely loose the previous update....
Is there any way for the selections to be kept while the installer may have to restart? Like the keyboard/language options.
In line with this is the loadkeys dialog which should rather be accessible as an option, not be mandatory, as it is tedious to choose everytime the script is called and will be set for the whole session anyways, I don't remember if you store this as variable, would be easy
The script has now the same behavior as udpate part. See NETWORKCHECK and KEYBOARDCHECK variable at install.conf file. When you launch for the first time the script, it will pass through the network and keyboard function and pass the variable to no and so if you restart the script those functions will not be called anymore.
The auto partition process is very well done and extremely satisfying to use but /home is forced to be separately formatted which may not be what I want, you could argue that I should then do manual partitioning but this is a very basic concept.
A workaround could simply be to compare the entered size with the left over size and if it was everything left then not prompt for home at all, since it's apparent that the user does not account for a separate partition [[ "${root_size}" = "${disk_size}" ]] && (skip the home stuff)
Would be gentler to ask for a separate home but it may work like that
Currently the script will throw an error if I enter every MB left for /root
hum, i will see what can i do. I think it miss a simple instructions text to be clear about the partition scheme used at auto-part choice. I was surprised about your /home request. I thought about the same thing but for the swap part. Who need a swap actually? old machine maybe?.
Anyway, i will fix that.
There's just generally speaking too much color going on, from a design view point it should be no more than two to three, the less the better, make it Obarun [would love to assist]
Totally agreed
The "Test network connection" could be a --gauge since it's really not that important to debug
Not possible with a simple way. the check take 3second more or less, so i think complicating the code for this is not really necessary.
The "instructions" are superfluos and an extra click, they also take a lot of time to read and grasp. Multi-stepped forms should be as short chained as possible. The necessary informative explanations can be made on each screen, as it is anyways
Coming from this it is tedious if canceled out of the script to always confirm this dialog
Yeah, i should review that
Firmware detection does not work (booted VM with UEFI) which is curious because your test for efivars is correct, needs debugging/inspection
need to test this, maybe a VM issue
IHMO the code is way too complex on many ends, but it is a matter of coding style and the script is nothing too crucial for many people to work on so it's not a real issue
Well, the partition.sh file contain more or less 400 line of code which is few to provide auto and manual partition. But i'm open for MR coming from you(not guarantee to be accepted though)
Wording/grammar/expression could be optimized in several places
haaa, i expected that from you! please provide a good one
When choosing "Done" on the disk selector dialog for manual partition the script exits, would be better UX to offer to cancel and have the cancel return to the menu from before
fixed
We're talking about a UI that is supposed to get Obarun installed on a computer in the shortest and easiest way possible
agreed
Graphic and UX/UI Design calls for usability before anything else in this case
agreed, no need a awesome GTK button
The less visual intrusion the faster the users eye will scan through the options
agreed mostly for my old eyes
Consider adding --no-tag for this reason as it's just for the script case not for information, it adds visual clutter slowing down decision making; you could argue that some users might benefit from ALT+# shortcuts but seriously,...how many of your user base are using this feature? I personally feel they're rather longmakes than shortcuts, just arrow up/down and return...
Well, the installer do not need a stepped ways to install the system. If you parts, format and mount the stuff before starting the script you just need to click install.You don't need to pass through the choice of the root directory before changing the template to use, and so on.
But, what about a new user? I prefer you version without the tag but i think it will be confusing for most of people, but you know what. Let's do it and see reports :p.
The current/active item in lists/radios/checkboxes/dselect etc. should really be a subtle change in color just enough to make it apparent when the item changes to active, this can be as easy as from white to white bold for example
Have the --backtitle be that. In the back. Do not make the eye want to focus it in any way
he non-bold CYAN from the Obarun ISO shell colors is almost exactly Obarun blue
Note how the actual wording [default variables] reflects exactly that in the menu, the user won't need to read the sentence at all to understand the meaning of the brackets
Note how a different wording can express way faster what is expected from the user (actually I got the template one wrong, note how it's misleading now; but it should be more descriptive to begin with)
he (optional) tags could be added in the same color as the text and not as square brackets as to not make them appear a greyed out variable, as they're not a default value but rather a description
Totally agreed. You really should be the official Obarun designer director :) even if you don't have so much time to help, your professionnal view is always in the right way.
Also maybe I'm blind at the moment but it's not apparent to me where to select the keyboard layout for the X server to be installed ($XKEYMAP)? I actually think it's missing.
The script will choose between KEYMAP and XKEYMAP depending if you come from console or X. This is done by the set_keymap() function.
The fact to hard code the keymap list is made to avoid an ugly parse like you did(no offense here). The keymap list come from the file that you parse and so cover the vast majority of the case without complicating the code.
But , maybe i should review the list a little bit....